Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 support #3278

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Drop Python 3.7 support #3278

merged 2 commits into from
Oct 6, 2023

Conversation

ordabayevy
Copy link
Member

Addresses #3276 and #3269

@ordabayevy ordabayevy requested a review from fritzo October 6, 2023 01:42
@fritzo fritzo added this to the 1.9 release milestone Oct 6, 2023
@fritzo fritzo added the breaking label Oct 6, 2023
fritzo
fritzo previously approved these changes Oct 6, 2023
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@@ -152,7 +152,6 @@
"License :: OSI Approved :: Apache Software License",
"Operating System :: POSIX :: Linux",
"Operating System :: MacOS :: MacOS X",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add 3.10, 3.11, 3.12 or whatever are supported by PyTorch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear if Python 3.12 is supported by PyTorch so skipped it for now.

@fritzo fritzo merged commit 44ba2d2 into dev Oct 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] mypy global python version too old Drop Python 3.7 support
2 participants